test(iroh-net): fix relay's codec proptesting #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
| @@ -101,8 +101,6 @@ pub(crate) enum FrameType { | |||
| /// | |||
| /// Handled on the `[relay::Client]`, but currently never sent on the `[relay::Server]` | |||
| Restarting = 15, | |||
| /// 32B src pub key + 32B dst pub key + packet bytes | |||
| ForwardPacket = 16, | |||
There was a problem hiding this comment.
@ramfox this was part of the compilation failures, but I think was part of meshing. Is this correct? it's otherwise not used anywhere
flub
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2278
proptest take overall less than 2 seconds, which I think is fast enough compared to the time of compiling in release and running all the tests.
Regression prop test was not being used (it was in a derp path) and it's obsolete since the client info message changed at some point
Breaking Changes
n/a
Notes & open questions
n/a
Change checklist
Documentation updates if relevant.All breaking changes documented.